Add lexical-binding comment to xml-query.xml#556
Open
affe-mit-waffel wants to merge 1 commit intoskeeto:masterfrom
Open
Add lexical-binding comment to xml-query.xml#556affe-mit-waffel wants to merge 1 commit intoskeeto:masterfrom
affe-mit-waffel wants to merge 1 commit intoskeeto:masterfrom
Conversation
* Lexical binding will be the default in Emacs 31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm running Emacs 31 and have noticed a warning about a "missing ‘lexical-binding’ cookie" in xml-query.xml.
Emacs 31 makes lexical-binding the default and shows that warning when it's not enabled: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74145.
Is there a reason why lexical-binding was not active in the file? Is it by design?
I have not found any incompatibilities yet BUT I'm not very familiar with the codebase and my elisp-foo is mid-level.
No issues on my machine so far though.